Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1st task #1

Merged
merged 5 commits into from
Oct 23, 2024
Merged

1st task #1

merged 5 commits into from
Oct 23, 2024

Conversation

AlekseyIsaev89
Copy link
Contributor

function sum inplemitation

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 17, 2024

Спасибо за отправленный пулриквест, теперь @SinimaWath должен запустить тесты.

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 18, 2024

Добавляю преподавателя (@SinimaWath) для код-ревью.

Comment on lines 3 to 6
if (( strtoLowerCase.includes('1xbet') ) || ( strtoLowerCase.includes('xxx') )) {
return true;
}
return false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут if, лишний, так как операция и так возвращает boolean:

return strtoLowerCase.includes('1xbet') || strtoLowerCase.includes('xxx')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Внес изменения в 4-й задаче. Прошу вас проверить.

@jsru-1 jsru-1 merged commit 10b1da8 into js-tasks-ru:master Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants