Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

05-dom-document-loading task #5

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

abrosimovsp
Copy link

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 10, 2024

Добавляю преподавателя (@ufocoder) для код-ревью.


NotificationMessage.lastShownElement = this

let timer = setTimeout(() => this.destroy(), this.duration)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.timerId = ..

}

destroy() {
clearTimeout(this.timer)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.timerId

@jsru-1
Copy link
Contributor

jsru-1 commented Oct 10, 2024

Добавляю преподавателя (@ufocoder) для код-ревью.

@jsru-1 jsru-1 requested a review from ufocoder October 10, 2024 16:46
@jsru-1 jsru-1 merged commit 8a83233 into js-tasks-ru:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants