-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work to support Active Record 7.1 (Rails 7.1.x) #1150
Commits on Jul 23, 2024
-
Ignore some files and update active record version to the latest 7.1
- .jrubyrc, to enable some extra debugging - .solargraph.yml and .rubocop.yml, for lsp in my editor - pik.sh, to pick my version of jruby to run test
Configuration menu - View commit details
-
Copy full SHA for 0a96569 - Browse repository at this point
Copy the full SHA 0a96569View commit details -
Temporarily disable jndi connection pool callbacks, we need to fix th…
…is later. - it was disabled to so we can focus on fixing the AR integration first - cannot run tests, process crashes
Configuration menu - View commit details
-
Copy full SHA for 11bd7d2 - Browse repository at this point
Copy the full SHA 11bd7d2View commit details -
Temporarily disable ARJDBC statement caching, we need to fix this later.
- it was disabled to so we can focus on fixing the core part first - cannot run tests, process crashes
Configuration menu - View commit details
-
Copy full SHA for 7c85e93 - Browse repository at this point
Copy the full SHA 7c85e93View commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 648b769 - Browse repository at this point
Copy the full SHA 648b769View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31ffac6 - Browse repository at this point
Copy the full SHA 31ffac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 354dfd1 - Browse repository at this point
Copy the full SHA 354dfd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c156643 - Browse repository at this point
Copy the full SHA c156643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 450359d - Browse repository at this point
Copy the full SHA 450359dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aac97a2 - Browse repository at this point
Copy the full SHA aac97a2View commit details
Commits on Jul 25, 2024
-
Fix postgres version tests failures
we needed to add new_client class method similar to active record CRuby adapters so we can easily mock the raw_connection.
Configuration menu - View commit details
-
Copy full SHA for e0e8b41 - Browse repository at this point
Copy the full SHA e0e8b41View commit details -
Configuration menu - View commit details
-
Copy full SHA for da7c41f - Browse repository at this point
Copy the full SHA da7c41fView commit details -
Fix test fetching columns of not existing table
<ActiveRecord::StatementInvalid> expected but was <ActiveRecord::JDBCError(<java.sql.SQLSyntaxErrorException: Table 'arjdbc_test.animals' doesn't exist>) arjdbc/jdbc/RubyJdbcConnection.java:775:in `execute'
Configuration menu - View commit details
-
Copy full SHA for a5fe20d - Browse repository at this point
Copy the full SHA a5fe20dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7bba82 - Browse repository at this point
Copy the full SHA e7bba82View commit details -
Fix mysql test failure to deprecated to_s(:db) method
Loading development environment (Rails 7.0.8.4) [1] pry(main)> t = Time.current => Thu, 25 Jul 2024 16:56:41.434382638 AEST +10:00 [2] pry(main)> [3] pry(main)> t.to_s(:db) DEPRECATION WARNING: TimeWithZone#to_s(:db) is deprecated. Please use TimeWithZone#to_fs(:db) instead. (called from require at bin/rails:4) => "2024-07-25 06:56:41"
Configuration menu - View commit details
-
Copy full SHA for 3e1bf96 - Browse repository at this point
Copy the full SHA 3e1bf96View commit details -
Fix several schema dump test for postgres
https://github.com/rails/rails/blob/7-1-stable/activerecord/lib/active_record/connection_adapters/mysql2/database_statements.rb#L21 https://github.com/rails/rails/blob/7-1-stable/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L63 there is diference between mysql/sqllite and postgres internal_exec_query method arity however due default values is not a issue at least for AR 7.1 some error example: Error: test_schema_dump(PostgresSchemaDumpTest): ArgumentError: unknown keywords: :allow_retry, :materialize_transactions /home/jessec/bryk/vendor_gems/stable/activerecord-jdbc-adapter/lib/arjdbc/abstract/database_statements.rb:37:in `internal_exec_query' /home/jessec/.gem/jruby/3.1.4/gems/activerecord-7.1.3.4/lib/active_record/connection_adapters/postgresql/schema_statements.rb:549:in `foreign_keys'
Configuration menu - View commit details
-
Copy full SHA for e65a725 - Browse repository at this point
Copy the full SHA e65a725View commit details -
Fix postgres test about fetching columns of non existent table
error: <ActiveRecord::StatementInvalid> expected but was <ActiveRecord::JDBCError(<org.postgresql.util.PSQLException: ERROR: relation "animals" does not exist Position: 454>)
Configuration menu - View commit details
-
Copy full SHA for 90e579f - Browse repository at this point
Copy the full SHA 90e579fView commit details -
fix savepoint test, it seems transaction needs to be materialized bef…
…ore creating a savepoint change relates to rails/rails@3f19431 materilaization is trigger by executing any query inside the transaction Cherry-picked from my fork
Configuration menu - View commit details
-
Copy full SHA for 1383039 - Browse repository at this point
Copy the full SHA 1383039View commit details -
Configuration menu - View commit details
-
Copy full SHA for c77c239 - Browse repository at this point
Copy the full SHA c77c239View commit details