Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce misleading of cluster edges #1973

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Sep 6, 2024

This PR overhauls the edge still of the cluster graph, to make them misleading (for example, that an edge with a similarity of 90% can have the minimal thickness and opacity)
The edge thickness is now clamped between 0 and 100 percent instead of the min and max
The edge opacity is now mapped between the max and the smaller value of 50% or the min

More detailed math

Lets call the highest similarity of any comparison in the cluster $sim_{max}$ and the lowest $sim_{min}$.
Lets take a comparison with similarity $sim$.
Its thickness will be equal to:
$thickness = \frac{sim - 0}{1 - 0} * 5 + 1 = sim * 5 + 1$
Opacity is calculated like this:
$opacity = \frac{sim - min(sim_{min}, 0.5)}{sim_{max} - min({sim_{min}}, 0.5)} * 0.7 +0.3$

Comparison 1
Members
Old
New
Comparison 2
Members
Old
New
Comparison 3 Left old, right new

Copy link

sonarcloud bot commented Sep 6, 2024

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Sep 6, 2024
@tsaglam tsaglam added this to the 6.0.0 milestone Sep 6, 2024
@tsaglam tsaglam merged commit 29e90a7 into develop Sep 9, 2024
51 checks passed
@tsaglam tsaglam deleted the report-viwer/better-cluster-edges branch September 9, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants