Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toast for new version notification #1892

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jul 27, 2024

With version 6.0.0 the landing will be seen less often and a new version notification on it is not ideal anymore.
This PR moves the notification to a toast
grafik

…version-toast

# Conflicts:
#	report-viewer/src/components/VersionInfoComponent.vue
#	report-viewer/src/viewWrapper/ComparisonViewWrapper.vue
@Kr0nox Kr0nox added this to the 6.0.0 milestone Jul 27, 2024
@Kr0nox Kr0nox linked an issue Jul 27, 2024 that may be closed by this pull request
@Kr0nox Kr0nox added enhancement Issue/PR that involves features, improvements and other changes report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies minor Minor issue/feature/contribution/change labels Jul 27, 2024
Copy link

sonarcloud bot commented Jul 27, 2024

@Kr0nox Kr0nox requested a review from a team July 29, 2024 10:27
@tsaglam tsaglam merged commit d9b000d into develop Aug 2, 2024
49 checks passed
@tsaglam tsaglam deleted the report-viewer/min-version-toast branch August 2, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version component with local report viewer
3 participants