Improve code quality of token sequence normalization #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… match merging is enabled to prevent interference.
tsaglam
added
enhancement
uuqjz
reviewed
Jul 16, 2024
core/src/main/java/de/jplag/normalization/TokenSequenceNormalizer.java
Outdated
Show resolved
Hide resolved
TwoOfTwelve
approved these changes
Jul 17, 2024
|
Had some time to do some systematic testing. I will paste the results under this comment. Toggle me!
TicTacToe + GPT-4 Obfuscation:
TicTacToe + Insertion-based Obfuscation:
PROGpedia-19 + Insertion-based Obfuscation:
TL;DR: I cannot reproduce the issue at a large scale. Thus, I remove the disabled sorting from this PR. However, I will keep the PR as the code quality improvements to TSN are good. The title and description will be adapted. |
tsaglam
changed the title
tsaglam
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the code quality of the token sequence normalization module:
Old Description (Outdated)
Run token sequence normalization (
--normalize) without topological sorting whenever match merging (--match--merging) is enabled to prevent interference. This PR also adapts the naming ofTokenStringNormalizertoTokenSequenceNormalizerwhich is the terminology used in JDoc and the scientific literature.This PR also refactors the token sequence normalization to improve code quality.
Background:
The reordering of tokens to normalize the token order helps to improve detection quality slightly, but the main impact comes from dead token removal. When match merging is also enabled, it struggles to revert split matches due to the sorting of the token sequence normalization. Thus, when using both, the topological sorting is now disabled in favor of match merging.