Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up report viewer code #1867

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Clean up report viewer code #1867

merged 6 commits into from
Jul 19, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jul 11, 2024 •
edited
Loading

This PR fixes different issues found in the code analysis programs:

  • Issues found by JetBrains static code analysis
  • Typos
  • Sonarcloud issues
  • Google lighthouse
  • Qodana

@Kr0nox Kr0nox changed the base branch from main to develop July 11, 2024 10:35
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jul 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 15, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Kr0nox Kr0nox marked this pull request as ready for review July 15, 2024 10:33
@Kr0nox Kr0nox requested a review from tsaglam July 15, 2024 10:33
@tsaglam tsaglam merged commit 6827d44 into develop Jul 19, 2024
49 checks passed
@tsaglam tsaglam deleted the report-viewer/cleanup branch July 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @tsaglam