Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx bug with --enable-preview on Java 22 #1854

Merged
merged 3 commits into from
Jul 10, 2024
Merged

FIx bug with --enable-preview on Java 22 #1854

merged 3 commits into from
Jul 10, 2024

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Jul 9, 2024 •
edited
Loading

Fix a bug occurring on Java 22 caused by the --enable-preview option that is enabled for the Java language module (see #1851):

  • Use the runtime Java version as the release version for the JavaC compilation task instead of the hardcoded version 21.
  • Only use hardcoded language version in the Java feature test.
  • Use constants for options flags.
  • Use a short link in the StackOverflow comment.

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Jul 9, 2024
@tsaglam tsaglam requested a review from a team July 9, 2024 14:57
@tsaglam tsaglam marked this pull request as ready for review July 9, 2024 15:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam added this to the 6.0.0 milestone Jul 10, 2024
@tsaglam tsaglam merged commit c67f62f into develop Jul 10, 2024
44 checks passed
@tsaglam tsaglam deleted the fix/preview-issues branch July 10, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss approved these changes

@TwoOfTwelve TwoOfTwelve TwoOfTwelve approved these changes

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tsaglam @dfuchss @TwoOfTwelve