Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance search bar of comparison table #1839

Merged
merged 8 commits into from
Jul 8, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jul 3, 2024

This table adds new features to the search bar of the comparison table.

It is now possible to search for index. If a number is written, it will take all indexes containing this number. E.g. when 5 is written in the search bar 5, 15 and 51 are displayed.
To get a specific index only, the number can be prefaced with index:. E.g. index:5 will only filter the 5th comparison in the current sorting.

It is now possible to filter for similarities. All these filters need to be prefaced with either >, <, >= or <= followed by the number of percentages to filter for. This searches over all similarities. A percentage symbol is optional. E.g. <100 will show all comparisons where any metric (so either avg or max) is less than 100%.
It is possible to filter for a specific metric by prefacing the comparison symbol with its name in the table header, followed by a double colon. E.g. max:>=90% will filter for submission where the maximum similarity is greater than or equal to 90%.

This is also explained in the tooltip of the search bar.
Due to the tooltip being cutoff, its direction changed.

@Kr0nox Kr0nox requested review from TwoOfTwelve and a team July 3, 2024 13:50
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jul 3, 2024
@tsaglam tsaglam added this to the 6.0.0 milestone Jul 3, 2024
@Kr0nox Kr0nox linked an issue Jul 7, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing.

report-viewer/src/components/ComparisonTableFilter.vue Outdated Show resolved Hide resolved
Kr0nox and others added 2 commits July 8, 2024 11:15
Copy link

sonarcloud bot commented Jul 8, 2024

@Kr0nox Kr0nox requested a review from tsaglam July 8, 2024 10:19
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tsaglam tsaglam merged commit 8fe5bdf into develop Jul 8, 2024
49 checks passed
@tsaglam tsaglam deleted the report-viewer/enhance-search branch July 8, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance search bar for comparison table
3 participants