Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Basecode in report viewer #1825

Merged
merged 15 commits into from
Jul 8, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jun 24, 2024

Basecode now gets displayed in the report viewer.
grafik

In the report there now is a new folder called basecode with one file per submission.

In the report viewer they get converted into the same structure as regular matches, when displaying a comparison.

A hint for the color is included in the match list
grafik

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor issues below. I tested the feature, and it looks good. However, currently, the basecode bubble in the breadcrumb bar is not clickable; this might confuse users, not sure. What are your thoughts on that?

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jul 1, 2024
@tsaglam tsaglam added this to the 6.0.0 milestone Jul 1, 2024
@Kr0nox
Copy link
Member Author

Kr0nox commented Jul 1, 2024

the basecode bubble in the breadcrumb bar is not clickable

I though about implementing that, but didnt know what to do when the basecode is split into multiple parts

Kr0nox and others added 2 commits July 1, 2024 20:17
Co-authored-by: Timur Sağlam <[email protected]>
@tsaglam
Copy link
Member

tsaglam commented Jul 2, 2024

I thought about implementing that, but didn't know what to do when the basecode is split into multiple parts

Good question, either jump to the first one, or we keep it unclickable. We can also discuss this in our meeting, maybe somebody else has a good idea.

@tsaglam
Copy link
Member

tsaglam commented Jul 4, 2024

Things to check:

  • Basecode only matches one submission in the comparison
  • Basecode split into multiple matches.

Copy link

sonarcloud bot commented Jul 6, 2024

@Kr0nox
Copy link
Member Author

Kr0nox commented Jul 6, 2024

When one submission does not have basecode, it does now say it in the tooltip
grafik

Copy link

sonarcloud bot commented Jul 6, 2024

@Kr0nox Kr0nox linked an issue Jul 7, 2024 that may be closed by this pull request
@tsaglam tsaglam merged commit 15058d4 into develop Jul 8, 2024
54 checks passed
@tsaglam tsaglam deleted the report-viewer/display-base branch July 8, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Base code in comparison
2 participants