Add Tool Tip for Bread Crumbs in Comparison View #1717
Conversation
Kr0nox
added
enhancement
Kr0nox
changed the title
…m/jplag/JPlag into report-viewer/breadcrump-tooltips
| return new Match(firstFileName, secondFileName, startLineFirst, startColumnFirst, endLineFirst, endColumnFirst, startLineSecond, | ||
| startColumnSecond, endLineSecond, endColumnSecond, match.length()); | ||
| return new Match(firstFileName, secondFileName, startLineFirst, startColumnFirst, startTokenFirst, endLineFirst, endColumnFirst, | ||
| endTokenFirst, startLineSecond, startColumnSecond, startTokenSecond, endLineSecond, endColumnSecond, endTokenSecond, match.length()); |
There was a problem hiding this comment.
@tsaglam Maybe we should think about splitting up the Match class in the future. For now I would keep it as is, so we don't break our API more than necessary.
There was a problem hiding this comment.
Was thinking the same, already have made a card for that on the board
There was a problem hiding this comment.
Yeah, I agree. We could just do I class for token subsequences, and a match just takes two subsequences.
|
|
|
|
|
|
|
|
This PR adds tooltips in breadcrumps.
In addition it adds an export of the start and end index of the tokenlist for each match. This change is backwards compatible with 5.0.0 and earlier.
Tooltip in 5.1.0:
Tooltip in 5.0.0:
Moreover it includes a rework of the tooltip component. It now can grow outside of a container that has overflow set to hidden, auto or scroll
Fixes #1668