Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate go language module to new framework #1694

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

Migrates the go language module to the new framework and adds some small features to the framework.

The tokens extracted for the complete example are still the same.
The token positions and lengths should be correct.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Apr 10, 2024
@tsaglam tsaglam added this to the 5.1.0 milestone Apr 10, 2024
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add concise but useful JDoc comments to the classes that are missing them?

Copy link

sonarcloud bot commented Apr 23, 2024

@tsaglam tsaglam merged commit d44028f into develop Apr 25, 2024
35 checks passed
@tsaglam tsaglam deleted the feature/migrateGoLanguageModule branch May 2, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants