Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicate root directory names #1495

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jan 22, 2024

This PR fixes the problems caused by having two root directories with the same same as described in #1445 by throwing an exception when two last folders have the same name

@Kr0nox Kr0nox requested a review from tsaglam January 22, 2024 21:10
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing...

core/src/main/java/de/jplag/JPlag.java Outdated Show resolved Hide resolved
@Kr0nox Kr0nox requested a review from tsaglam January 25, 2024 15:21
@tsaglam tsaglam merged commit 48fd672 into develop Jan 26, 2024
8 checks passed
@tsaglam tsaglam deleted the bugfix/same-root-name branch January 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants