Add --normalize flag for Java #1155
Conversation
tsaglam
added
enhancement
|
The way you documented the normalization flag indicates it is a global option. If your intent is a global option, that can be applied to all languages I would suggest adding it as a global option and just passing the value to the language for parsing. If the intent is a language specific option, that is available for all languages you could also add it to the global LanguageOptions class. Otherwise I could easily add a mechanism for shared options. Language specific options should only affect a single language module and should not be refereed to from the core module. |
|
I implemented an alternative way to add the flag. The branch is named normalize-flag-suggestion. |
|
Thanks, where can I view it? Your JPlag fork isn't public |
|
I committed it to your fork |
|
You can do that? I can't find it |
|
Sorry, I don't like forks very much, so I rarely use them. I forked your fork and pushed my branch here: https://github.com/TwoOfTwelve/JPlagMbrdl/tree/normalize-flag-suggestion |
|
Looks good, thanks 👍 |
|
But maybe normalization shouldn't be a language-specific option at all, since in principle any language can support it. Maybe it should just be a global option with a disclaimer. idk |
| @@ -125,6 +125,9 @@ Advanced | |||
| -x, --exclusion-file=<exclusionFileName> | |||
| All files named in this file will be ignored in the | |||
| comparison (line-separated list) | |||
|
|
|||
| --normalize (Java only) Enable token string normalization, | |||
| which can help detect certain cases of plagiarism. | |||
There was a problem hiding this comment.
This documentation does not fit the implementation. This implies, that --normalize is a global argument, but it is implemented as language specific.
| @@ -67,6 +67,9 @@ Advanced | |||
| -x, --exclusion-file=<exclusionFileName> | |||
| All files named in this file will be ignored in the | |||
| comparison (line-separated list) | |||
|
|
|||
| --normalize (Java only) Enable token string normalization, | |||
| which can help detect certain cases of plagiarism. | |||
|
|
||
| public class JavaLanguageOptions extends LanguageOptions { | ||
| public JavaLanguageOptions() { | ||
| super(true); |
There was a problem hiding this comment.
This solution is fine, if we choose to implement --normalize as a language specific option.
tsaglam
added
the
language
|
@mbrdl we still have some open requests here. |
| @@ -0,0 +1,38 @@ | |||
| package de.jplag.options; | |||
|
|
|||
| class DummyOption<T> implements LanguageOption<T> { | |||
| this.options = new ArrayList<>(); | ||
| if (supportsNormalization) { | ||
| var description = "Enable token string normalization, which can help detect certain cases of plagiarism."; |
There was a problem hiding this comment.
Avoid var, especially when String is nearly just as short.
|
Putting this off for now due to unresolved design decisions and lack of urgency |
|
todo: add cli tests for the flag |
# Conflicts: # languages/java/src/main/java/de/jplag/java/JavaLanguage.java
|
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed! |
|
@mbrdl this branch has some merge conflicts; could you resolve them :) |
|
This PR is on ice for now, we'll probably implement the option globally instead |
Adresses #1028. I'm not too happy with the way language-specific options work right now but I guess that's a topic for another day.