This repository has been archived by the owner on Apr 29, 2023. It is now read-only.
Issue 54, basic SSR without treeshaking location.state and location.actions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 68 69 +1
Branches 11 12 +1
=====================================
+ Hits 68 69 +1
Continue to review full report at Codecov.
|
jcperez-ch
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple check for
undefinedto the window and history objects to avoid errors when using@hyperapp/routeron the server side in combination with@hyperapp/render.Assuming the
subscribemethod is only used in the client side.https://github.com/hyperapp/router/issues/54