Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing and examples for run and run_to_completion #66

Merged
merged 10 commits into from
Jul 14, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented May 20, 2024

This PR is also adding:

  • tracing dep and emitting heartbeat event at trace level - so that we know that we are healthy;
  • examples run and run_to_completion;

This change is Reviewable

@rustworthy rustworthy requested a review from jonhoo May 20, 2024 12:28
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.0%. Comparing base (a4832db) to head (9974a67).

Additional details and impacted files
Files Coverage Δ
src/worker/health.rs 77.2% <87.5%> (+1.6%) ⬆️

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small nits!

README.md Show resolved Hide resolved
examples/run.rs Outdated Show resolved Hide resolved
examples/run.rs Outdated Show resolved Hide resolved
examples/run.rs Show resolved Hide resolved
examples/run.rs Outdated Show resolved Hide resolved
examples/run.rs Outdated Show resolved Hide resolved
src/worker/health.rs Outdated Show resolved Hide resolved
src/worker/health.rs Outdated Show resolved Hide resolved
@rustworthy
Copy link
Collaborator Author

rustworthy commented May 26, 2024

@jonhoo Please have a look at this PR once again.

The tests are actually failing for the main branch, which is will be fixed in a dedicated PR: we simply need to adjust a couple of tests to use Client::current_info instead of the retired Client::info.

UPDATE: addressed in #68

@rustworthy rustworthy requested a review from jonhoo May 26, 2024 08:09
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now — time to land 🛬

@jonhoo jonhoo merged commit f6caee4 into main Jul 14, 2024
19 checks passed
@rustworthy rustworthy deleted the chore/tracing_and_examples branch July 14, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants