Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServerState and Client::current_info #63

Merged
merged 17 commits into from
May 25, 2024
Merged

Add ServerState and Client::current_info #63

merged 17 commits into from
May 25, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented May 20, 2024

Addresses #60

We will also add sets to DataSnapshot struct as soon as the Faktory server starts returning it.


This change is Reviewable

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.0%. Comparing base (eac9545) to head (a36bf2a).

Additional details and impacted files
Files Coverage Δ
src/proto/client/mod.rs 86.9% <100.0%> (+3.4%) ⬆️
src/proto/mod.rs 50.0% <ø> (ø)
src/proto/single/ent/progress.rs 0.0% <ø> (ø)
src/proto/single/resp.rs 87.6% <100.0%> (+0.1%) ⬆️
src/proto/single/utils.rs 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@rustworthy rustworthy changed the title Add ServerStete and Client::current_info Add ServerState and Client::current_info May 20, 2024
@rustworthy rustworthy requested a review from jonhoo May 20, 2024 06:49
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, mostly nits!

src/proto/single/resp.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
@rustworthy rustworthy requested a review from jonhoo May 21, 2024 14:49
tests/real/community.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
src/proto/single/resp.rs Outdated Show resolved Hide resolved
tests/real/community.rs Outdated Show resolved Hide resolved
@jonhoo jonhoo merged commit 58962df into main May 25, 2024
19 checks passed
@rustworthy rustworthy deleted the feat/server_state branch May 26, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants