Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job builder #37

Merged
merged 33 commits into from
Jan 3, 2024
Merged

Job builder #37

merged 33 commits into from
Jan 3, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented Dec 3, 2023 •
edited by jonhoo
Loading

As per feature request

This change is Reviewable

@rustworthy
Use 'derive_builder' macro for 'Job'
1552f75
@rustworthy
Add initial test for 'JobBuilder'
69e6836
@rustworthy
Add client-side error group, add 'MalformedJob'
d389b19
@rustworthy
Add custom build remapping to 'MalformedJob' err
3aa1599
@rustworthy
Add 'single/utils' mod with 'gen_random_jid' utility
e888e39
@rustworthy
Rm duplicated import in Job::new
21e6dbb
@rustworthy
Use 'gen_random_jid' as 'jid' default on 'Job' struct
88a3d77
@rustworthy
Add builder default for 'gueue' field on 'Job' struct
ede140b
@rustworthy
Add test for required fields in 'Job'
f1f3b34
@rustworthy
Add defaults for 'created_at', 'enqueued_at' and 'at' fields
6885a3b
@rustworthy
Add defaults for 'reserved_for', 'retry' and 'priority' fields
21179ac
@rustworthy
Add custom validator, check priority is valid
c41e4a0
@rustworthy
Add test for job created with 'JobBuilder'
ca2bbdc
@rustworthy
Use constants in Job::new
a824b5c
@rustworthy
Align API of Job::new and JobBuilder
414e73e
@rustworthy
Make JobBuilder publicly available
7081990
@rustworthy
Add demo usage of 'JobBuilder' to loadtest
ac361ae
@rustworthy
Do clean up before PR submitting
6700c11
@rustworthy rustworthy changed the title [WIP] Job builder Job builder Dec 5, 2023
@rustworthy rustworthy mentioned this pull request Dec 9, 2023
Open
jonhoo
jonhoo requested changes Dec 17, 2023
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good starting point, thanks for taking the time! Left some comments.

src/bin/loadtest.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b63eadf) 70.0% compared to head (9d5dc16) 72.4%.
Report is 2 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
src/proto/mod.rs 79.5% <ø> (+0.9%) ⬆️
src/proto/single/utils.rs 100.0% <100.0%> (ø)
src/proto/single/mod.rs 93.2% <98.5%> (+6.4%) ⬆️

... and 4 files with indirect coverage changes

jonhoo
jonhoo requested changes Jan 3, 2024
View reviewed changes
src/proto/single/mod.rs Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
src/proto/single/mod.rs Outdated Show resolved Hide resolved
@jonhoo
Copy link
Owner

jonhoo commented Jan 3, 2024

We can ignore the minimal versions failure — I'll have to do some manual stuff to fix that I think.

@jonhoo jonhoo merged commit 0fbcb22 into jonhoo:main Jan 3, 2024
15 of 16 checks passed
@jonhoo
Copy link
Owner

jonhoo commented Jan 3, 2024

I'll hold off on releasing this until #34 lands.

@jonhoo
Copy link
Owner

jonhoo commented Jan 3, 2024

Released in 0.12.2 🎉

@rustworthy rustworthy deleted the feat/job-builder branch January 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustworthy @jonhoo