-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover loadtest bin with tests #36
Conversation
I'm not sure I follow the reasoning behind this change. |
I believe it's easier to read and reason about when it's decomposed. Say, we will want to load test with some of new features in place: job tracker, who will send a job execution updates once the job is fetched. Then it will be easier to adjust the binary to accept these options from the command line. The fact (fakt) that we can now cover these separate procedures with tests is rather a side-effect, isn't it? :) |
Hmm, I actually find the new version significantly harder to read/follow than the old version 😅 I'd prefer to keep the old one until such time as we need the added flexibility of the more convoluted new one :) |
Loadtest functions as expected:
Coverage report for loadtest.rs (with suggested changes applied):
Overall ~10p.p. coverage increase from 69.88% to 79.46%:
This change is