Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed __TOP_CARD and get_name_and_location function in Person.py #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eaglesight02
Copy link

  • Changed the '__TOP_CARD' from __TOP_CARD="pv-top-card" to __TOP_CARD="scaffold-layout__main"
    __TOP_CARD(scaffold-layout__main) png

  • The top_panel (for name and location) is taken as multi-class element ".mt2.relative"
    CLASS_NAME( mt2 relative)

  • Name is taken by TAG_NAME for top_panel as "h1"
    TAG_NAME(h1)

  • Location is taken by multi-class name ".text-body-small.inline.t-black--light.break-words"
    CLASS_NAME( text-body-small inline t-black--light break-words)

@Eaglesight02
Copy link
Author

@joeyism could you please verify the commit and merge the PR?

@nateloeffel
Copy link

This code doesnt work. throws an error

@Eaglesight02
Copy link
Author

It maybe because of other functions, they also need some rework :)
But if I ran this separately, then I got the name and location.

@sach-12
Copy link
Contributor

sach-12 commented Jan 21, 2024

Check out #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants