-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate rhs after string slices #76
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 88.34% 88.25% -0.10%
==========================================
Files 12 12
Lines 2557 2562 +5
==========================================
+ Hits 2259 2261 +2
- Misses 204 206 +2
- Partials 94 95 +1
☔ View full report in Codecov by Sentry. |
@eddycharly can you please help me fix the linting errors ? |
@springcomp In depguard v1, enabling depguard without config do nothing. Disabling depguard in .golangci.yml or adding the following settings to .golangci.yml may fix the lint errors. linters-settings:
depguard:
rules:
main:
files:
- $all
- "!$test"
allow:
- $gostd
- github.com/jmespath-community/go-jmespath |
@eddycharly can I kindly request your help in having this PR moving forward ? Linter is now running OK but it seems to fail in codecov, possibly from using an expired token. |
Signed-off-by: Springcomp <[email protected]>
548adef
to
42fcb4e
Compare
Signed-off-by: Springcomp <[email protected]>
Signed-off-by: Springcomp <[email protected]>
42fcb4e
to
bc8f23a
Compare
Fixes #69.