Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate rhs after string slices #76

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Evaluate rhs after string slices #76

wants to merge 3 commits into from

Conversation

springcomp
Copy link
Contributor

Fixes #69.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.10 ⚠️

Comparison is base (4a4bfbf) 88.34% compared to head (548adef) 88.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   88.34%   88.25%   -0.10%     
==========================================
  Files          12       12              
  Lines        2557     2562       +5     
==========================================
+ Hits         2259     2261       +2     
- Misses        204      206       +2     
- Partials       94       95       +1     
Impacted Files Coverage Δ
pkg/interpreter/interpreter.go 76.32% <57.14%> (-0.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@springcomp
Copy link
Contributor Author

@eddycharly can you please help me fix the linting errors ?
Is there anything I do wrong?

@kit494way
Copy link

@springcomp
Since depguard v2, default behavior is changed.
OpenPeeDeeP/depguard#55

In depguard v1, enabling depguard without config do nothing.
OpenPeeDeeP/depguard#55 (comment)

Disabling depguard in .golangci.yml or adding the following settings to .golangci.yml may fix the lint errors.

linters-settings:
  depguard:
    rules:
      main:
        files:
          - $all
          - "!$test"
        allow:
          - $gostd
          - github.com/jmespath-community/go-jmespath

@springcomp
Copy link
Contributor Author

springcomp commented Oct 27, 2024

@eddycharly can I kindly request your help in having this PR moving forward ?

Linter is now running OK but it seems to fail in codecov, possibly from using an expired token.

Signed-off-by: Springcomp <[email protected]>
Signed-off-by: Springcomp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projected string slices are shortcut
2 participants