Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JT4 enablement #374

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

JT4 enablement #374

wants to merge 3 commits into from

Conversation

sq6emm
Copy link

@sq6emm sq6emm commented Feb 28, 2024

This is fixing #373

Screenshot from 2024-02-28 23-17-18

Copy link
Owner

@jketterl jketterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. The change looks good overall, just needs a final polishing pass, please see inline comments. Please also check the question about a potential impact on CPU usage by the increase in frequency tolerance. Cheers!

CHANGELOG.md Outdated Show resolved Hide resolved
docker.sh Outdated Show resolved Hide resolved
owrx/modes.py Outdated Show resolved Hide resolved
owrx/wsjt.py Show resolved Hide resolved
owrx/wsjt.py Outdated Show resolved Hide resolved
@sq6emm
Copy link
Author

sq6emm commented Jun 11, 2024

@jketterl how do you think, is it now old enough to be merged?:)

@jketterl
Copy link
Owner

Has there been any updates?

@sq6emm
Copy link
Author

sq6emm commented Jun 12, 2024

Well I believe for basic functionality nothing more needed? Decoding of JT4 is currently based on the default bandwidth. I also checked as you requested the CPU Increase and described them so you can decide if to implement a possibility to modify the decode bandwidth (that I consider as a feature update)... So well is there anything missing?

@jketterl
Copy link
Owner

Your initial response to the discussion about the -F parameter was:

This is needed capability especially on uWaves where frequencies are not stable enough.

This gave me the impression that being able to control the frequency tolerance was essential to this feature. As such, I did not consider merging this for as long as this setting is not available.

@sq6emm
Copy link
Author

sq6emm commented Jun 15, 2024

It's true, but with agile approach it's better to have a MVP;)

@sq6emm
Copy link
Author

sq6emm commented Oct 16, 2024

@jketterl any chance to merge it?

@jketterl
Copy link
Owner

Do you see any change? Did you do any changes yourself?

@sq6emm sq6emm closed this Oct 16, 2024
@jketterl jketterl reopened this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants