-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round frequency to 100Hz when clicking FFT display #172
base: develop
Are you sure you want to change the base?
Conversation
This will need to integrate with the actual frequency display in some way. I like the idea, but I know that some people have modified the frequency display to display more digits, and to them it will be rather odd. I think it's a good idea to make the frequency display precision configurable at some point, it already has most of the code. Also, the idea to have some configurable steps to snap to has been around before, but has not been fully discussed yet. See #136. |
I would like you to participate in the discussion before you build things. Otherwise you will find out very soon that I don't like the receiver controls to become cluttered with minor items. Thank you. |
I'd like to push these changes somewhere so you can evaluate them, and we can discuss what needs to be changed. I'm all for constructive criticism, that's what PRs are for. Where do you think such a control should be placed, and what it should look like? |
I don't think you understand. I don't have a space available where such controls should go at the moment, that's why I'm inviting you to the discussion. I'm not a big UX designer, but I'm trying to keep the main receiver controls somewhat clean and easy to understand, they should be very intuitive to control, even for radio novices. I am reminded of what it looks like when one just keeps adding features with no concept every time I visit a KiwiSDR receiver, and I won't allow the same to happen here. |
This has been a while now but still is relevant somehow. As a HF listener it is somehow painful to tune in to a SSB station. Nowadays these stations are most of the time really accurate tuned to a frequency ending on 0 in the 100Hz digit. At least most stations have a 0 in the 10Hz digit. My conclusion here would be: If we round the "clicked" frequency to the nearest 0 we have a better rate on hitting the "right" frequency at first try. In my opinion this would lead to a better tune experience. |
It could be an additional option in profile settings so you can set it 12.5kHz in in the FM profile and 100Hz in the HF profiles or whatever you want. But there still has to be a way to disable it, i don't know if you want another button or what the icon could be so it is obvious. I wouldn't like it to be cluttered also, until now it in nice and simple. |
But why? you always have the option to tune manually with the mouse wheel or by typing in the frequency. (Provided that the "snapping" or "rounding" only takes place by clicking in the waterfall. It would be great to link the settings to a mode though. Listening to broadcast FM takes way other tuning steps compared to CW or SSB |
Please also consider that this is not a 1:1 relation. Example: AM tuning is 9kHz steps on MW, but 10kHz on SW. NFM tuning may be 12.5kHz or 25kHz. The latter example may not be the critical one since that's a multiple. |
In my setup i would put a step of 100Hz on every ham band, because when i click on a signal i am usually off by less than 400Hz. Then i can quickly correct with the mouse wheel on the frequency display. I would suggest when you scroll the wheel on top of the waterfall (on the ruler?) , the frequency moves by the predefined steps for the band (same way it works on gqrx and sdr++). Or zoom on the ruler and frequency steps on the waterfall (as in gqrx). Only the first part would be fine, the second is just a shortcut not so importand. |
Would it be helpful to have something like
as an OPTION attached to each profile? If you have a "MW Broadcast" profile, you can do "big" steps, if you have a "40m HAM" profile, you can go with smaller steps or even no grid at all (no entry = no grid maybe?) |
This may make sense as a default, but I don't think it's a good idea to force it. The user should be able to override this. |
Ok, so we may need a UI-way to toggle between grid and "free tuning" without introducing new buttons. |
Well I don't know about the others, but for me, that's even less intuitive than just spamming buttons. Still looking for better UX ideas. |
The default is as it is. In (localhost)/settings/sdr/sdrplay/profile/20m you have the default options (profile name, sample rate ....). You can create a new profile and fill in the required settings as it is. On the bottom there are some "Additional optional settings" that are not required. The end user can only use the profiles you already configured. For each profile you (as admin) can set extra options like IF Mode or whatever is on "Additional optional settings" (as it is right now). So i suggest to just add another "Additional optional settings" for Frequency Step. It will exist there as an option, not default. It would be unique for each profile separately (as every other "Additional optional settings"). That is how i think it can be implement without changing the default behavior (or adding another complexity). BUT i don't know how it could be implemented on code. When you click on the waterfall to change frequency you have to take acount if the "Frequency Step" is set or not and then just round the value to "set" number or not. edit? i am just making suggestions that i think are constructive. i can't code and i am happy with the software as it is. this is not a request. |
As for UX - how about small tab(s) to the left side of the receiver with a small, contextual icon which when clicked animates an additional panel for additional settings such as this. |
Currently OWRX displays the tuner frequency in MHz with 4 decimal digits, omitting the last two. When clicking on the FFT waterfall it is then impossible to see which frequency you actually tuned to, and exactly 99 out of 100 times, it's not the one you want. Especially for SSB transmissions it's very impractical to tune by clicking, you end up always entering the frequency manually.
Solution: round the frequency to a multiple of 100Hz. I find that this one simple tweak is a massive increase in usability. Ideally I think the tuner window should show the full frequency in Hz, with a selection dropdown for grid/step size. I'd have to study the code more (and learn js) if I were to implement that, however. For now, I think this small change is already a step in the right direction.