Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crude implementation of CHIRP csv bookmarks import #11

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

D0han
Copy link

@D0han D0han commented Sep 29, 2019

This is very crude and ad-hoc implementation of openwebrx bookmarks extender/integrator.
It grabs path to CHIRP csv export supplied as parameter and combines it with existing bookmarks.

I know its dirty code, but figured someone may want to use it anyway.

@jketterl
Copy link
Owner

jketterl commented Oct 4, 2019

I am not sure if I do want to merge it into the codebase. I don't think many people are going to find it in there, but I do have a different reasoning. Right now, the bookmarks file is pretty static, and the way it has to be edited is kind of cumbersome. It is a simple solution for now, but I would like to improve on it, potentially making this solution obsolete.

Here's some of the ideas that I have right now, I'd love to see some feedback on those:

What I have in mind right now is some kind of editor, built into openwebrx's website, which allows the user (or maybe just the administrator, that will likely be a requirement) to edit the bookmarks on there. I might even go as far as making it realtime, so others will see their bookmarks updated at the same time they're edited.

This will probably have some kind of storage backend, and I'm thinking multiple implementations, like simple json, csv, or a database.

I think it would be best to offer some kind of import / export feature in that editor. That way you could easily feed your csvs (or whatever other format I get thrown at me that I can support) into the receiver.

What do you think?

@D0han
Copy link
Author

D0han commented Oct 4, 2019

Feel free to discard this pull request :)

That sounds pretty good to me, but please keep in mind that any value taken from user can be malicious - especially those passed to underlying system. Having admin and imports is even more risky (serialization exploits etc), so it is very important to have safe defaults (like serving on HTTPS only).

My use case is somewhat different than intended, as im the only user of my openwebrx instance in isolated network.
Important things for me are:

  • import/export
  • setting more than one bookmark on one freq

bkerler pushed a commit to bkerler/openwebrx that referenced this pull request Aug 26, 2023
bkerler pushed a commit to bkerler/openwebrx that referenced this pull request Aug 26, 2023
This reverts commit 9b88e61, reversing
changes made to 272b352.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants