Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check automatically Intel and Silicon MACS and minor fixes #85

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

superbonaci
Copy link

@superbonaci superbonaci commented Sep 15, 2024

Some fixes thanks to https://github.com/PWhiddy/drat

  • Detect argp-standalone version without hard coding it thanks to brew symlink
  • Fix int open_container__info_stream
  • Add -Wno-unused-but-set-variable
  • Update README.md to include command to install argp-standalone in MAC

@jivanpal
Copy link
Owner

I'll review your suggested Makefile changes once I get my hands on an Intel Mac again, because I'm not familiar with how Homebrew has changed its default behaviour since the introduction of Apple Silicon.

@superbonaci
Copy link
Author

Fixes #82 #84

I've tested both in a virtual machine one with arm and other with intel x86_64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

Successfully merging this pull request may close these issues.

2 participants