fix: status bar item duplication on conf reload #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleeraser
force-pushed
the
fix/duplication-on-reload
branch
3 times, most recently
from
48ca147
to
28b2fe8
Compare
This fixes a weird behavior where a custom status bar item (e.g. a prefix) would be duplicated in the status bar after a configuration reload. e.g. prior to this fix, setting: set -g @theme-status-left-prefix "test" and reloading the configuration multiple times would result in multiple 'test' strings being added as prefix. Fixes jimeh#54
aleeraser
force-pushed
the
fix/duplication-on-reload
branch
from
578befb
to
b4364f7
Compare
|
This resolves for me! What's the process to merge this PR? @jimeh |
Not sure if he's ever going to answer/merge this, last commit is over 5 years old. Anyway, you can temporarily use this fix by specifying:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a weird behavior where a custom status bar item (e.g. a prefix) would be duplicated in the status bar after a configuration reload.
e.g. prior to this fix, setting:
set -g @theme-status-left-prefix "test"
and reloading the configuration multiple times would result in multiple 'test' strings being added as prefix.
Fixes #54