Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix key and pane sync indicators #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimeh
Copy link
Owner

@jimeh jimeh commented Dec 23, 2019

The indicators used can be customized:

  • For the prefix key indicator, set @themepack-prefix-key-on-format
    and @themepack-prefix-key-off-format options. The off format must be
    the same length as the on format to avoid weird behavior.
  • For the pane sync indicator, set @themepack-pane-sync-on-format and
    @themepack-pane-sync-off-format options. The off format must be the
    same length as the on format to avoid weird behavior.

To-Do

  • Fix duplicated and glitchy indicators when reloading tmux configuration.
  • Figure out if there's an easy way for users disable the indicators if they don't want them.

Gifs

Prefix Key Indicator

Basic theme:

basic-prefix-key-indicator

Powerline themes:

powerline-prefix-key-indicator

Pane Sync Indicator

Basic theme:

basic-pane-sync-indicator

Powerline themes:

powerline-pane-sync-indicator

The indicators used can be customized:

- For the prefix key indicator, set `@themepack-prefix-key-on-format`
and `@themepack-prefix-key-off-format` options. The off format must be
the same length as the on format to avoid weird behavior.
- For the pane sync indicator, set `@themepack-pane-sync-on-format` and
`@themepack-pane-sync-off-format` options. The off format must be the
same length as the on format to avoid weird behavior.
@lovesegfault
Copy link

This looks awesome! Thank you!

@ori955
Copy link

ori955 commented Dec 23, 2019

thank you so much!
really like your work!

@Blake-LeBlanc
Copy link

Hey @jimeh ! Maybe I'm blind as a bat, but I can't seem to find where the @themepack-prefix-key-on-format and @themepack-prefix-key-off-format settings are located... Should I be looking for them within the theme I'm using? (for example, within the tmux-tmux/plugins/themepack/powerline/default/cyan.tmuxtheme file?)

@jimeh
Copy link
Owner Author

jimeh commented Mar 31, 2020

@Blake-LeBlanc Yeah, they should be defined within the theme file you're using. However make sure you're using the branch for this PR instead of master.

I've been meaning to find time for some final cleanup and added flexibility for this PR before I merge it, and so far it hasn't happened.

@Blake-LeBlanc
Copy link

@Blake-LeBlanc Yeah, they should be defined within the theme file you're using. However make sure you're using the branch for this PR instead of master.

I've been meaning to find time for some final cleanup and added flexibility for this PR before I merge it, and so far it hasn't happened.

Ahh, got it with the PR branch, thanks!

@yeslsudarshan
Copy link

Hey @jimeh! Let me first say, this is a great set of themes and this enhancement makes it even better. Thanks a lot for sharing this.

I tried this PR and things work great for the most part.

Only thing I noticed is that the status line gets messed up every time I source the tmux.conf and keeps adding separators on the Left and Right side.

Clean :
Clean

After sourcing .tmux.conf, notice the '>' separators:

Corrupted-1

And all the elements now indicate prefix key press:

Corrupted-2

Also, more separators get added every time tmux.conf is sourced:

Corrupted-3

@jimeh
Copy link
Owner Author

jimeh commented May 27, 2020

@yeslsudarshan thanks for bringing that to my attention. I hadn't noticed it myself, as it turns out I don't reload my tmux config very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants