Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbip_protocol: fix parser bug on cmd_submit and ret_submit #37

Merged
merged 2 commits into from
Dec 26, 2023
Merged

usbip_protocol: fix parser bug on cmd_submit and ret_submit #37

merged 2 commits into from
Dec 26, 2023

Conversation

h7x4
Copy link
Collaborator

@h7x4 h7x4 commented Dec 26, 2023

This PR fixes a critical error in the usbip protocol parser.

From https://docs.kernel.org/usb/usbip_protocol.html (USBIP_CMD_SUBMIT, USBIP_RET_SUBMIT)

0x30 - n - transfer_buffer. If direction is USBIP_DIR_OUT then n equals transfer_buffer_length; otherwise n equals 0. For ISO transfers the padding between each ISO packets is not transmitted.

0x30 - n - transfer_buffer. If direction is USBIP_DIR_IN then n equals actual_length; otherwise n equals 0. For ISO transfers the padding between each ISO packets is not transmitted.

Closes #36

@h7x4 h7x4 requested a review from jiegec December 26, 2023 15:55
@jiegec jiegec merged commit 8640fb4 into jiegec:master Dec 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegec jiegec Awaiting requested review from jiegec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devices no longer recognized since ecc21544
2 participants
@h7x4 @jiegec