Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced code duplication in ClassRegistry and introduced sorting in the ObjectsPlugin #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

j-riebe
Copy link
Contributor

@j-riebe j-riebe commented Apr 15, 2022

No description provided.

The duplicated methods per type `style style_XXX_class`, `generate_XXX` and `reference_XXX` were abstracted into a BaseTypeRegistry class.
Provided a specific XXXTypeRegistry for every required type and added it as an attribute to the ClassRegistry.
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #29 (8c07759) into master (0a2fd5a) will increase coverage by 0.73%.
The diff coverage is 88.59%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   92.08%   92.82%   +0.73%     
==========================================
  Files          47       47              
  Lines        2199     2187      -12     
==========================================
+ Hits         2025     2030       +5     
+ Misses        174      157      -17     
Impacted Files Coverage Δ
turms/registry.py 90.94% <88.43%> (+6.52%) ⬆️
turms/plugins/objects.py 95.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2fd5a...8c07759. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant