Add Applicability evidence to non-applicable vulnerabilities #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
improvement
github-actions
bot
removed
the
safe to test
attiasas
reviewed
Sep 22, 2024
src/main/treeDataProviders/issuesTree/descriptorTree/projectDependencyTreeNode.ts
Outdated
Show resolved
Hide resolved
…new added applicability results
dortam888
added
the
safe to test
github-actions
bot
removed
the
safe to test
dortam888
added
the
safe to test
github-actions
bot
removed
the
safe to test
dortam888
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
requested changes
Oct 9, 2024
| @@ -248,9 +251,20 @@ export class AnalyzerUtils { | |||
| evidence: evidences | |||
| } as IApplicableDetails; | |||
| } else { | |||
| // Not applicable | |||
| // Not Applicable | |||
There was a problem hiding this comment.
if cve is not in applicableCve does not automatic determined as not applicable any more.
You should take it into considerations, when happened on CVE that is undetermined/ not covered?...
There was a problem hiding this comment.
Currently. If a CVE is not in status applicable or not applicable I'll end in line 256 condition and will not assign a value.
dortam888
added
the
safe to test
github-actions
bot
removed
the
safe to test
dortam888
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Add Applicability evidence logic to non-applicable vulnerabilities. So far we had applicability evidence only for applicable status. Added the logic that non-applicable will also send API to webview to show.
Linked to webview fix: jfrog/jfrog-ide-webview#63