-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Applicability evidence to non-applicable vulnerabilities #497
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, check out my comments
src/main/treeDataProviders/issuesTree/descriptorTree/projectDependencyTreeNode.ts
Outdated
Show resolved
Hide resolved
…new added applicability results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests cases for CVE that are not applicable/not applicable
@@ -248,9 +251,20 @@ export class AnalyzerUtils { | |||
evidence: evidences | |||
} as IApplicableDetails; | |||
} else { | |||
// Not applicable | |||
// Not Applicable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if cve is not in applicableCve
does not automatic determined as not applicable any more.
You should take it into considerations, when happened on CVE that is undetermined/ not covered?...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently. If a CVE is not in status applicable or not applicable I'll end in line 256 condition and will not assign a value.
npm run format
for formatting the code before submitting the pull request.Add Applicability evidence logic to non-applicable vulnerabilities. So far we had applicability evidence only for applicable status. Added the logic that non-applicable will also send API to webview to show.
Linked to webview fix: jfrog/jfrog-ide-webview#63