Support Platform Access Token #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobiNino
added
safe to test
github-actions
bot
removed
the
safe to test
4 tasks
yahavi
requested changes
Sep 14, 2023
…f-access-token
RobiNino
added
the
safe to test
github-actions
bot
removed
the
safe to test
…f-access-token # Conflicts: # access/services/accesstoken.go # tests/accesstokens_test.go
RobiNino
added
the
safe to test
github-actions
bot
removed
the
safe to test
RobiNino
added
the
safe to test
github-actions
bot
removed
the
safe to test
…f-access-token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes in Access Token service:
CommonTokenParams.ExpiresIn: changed fromintto*uint. Pointer to allow sending it empty, thus providing the token with the platform's default expiry.uintbecause it does not accept negative values.Besides the changes above, this PR adds some missing fields to the access token structure.