Adding Xray Source Control Service #811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/analysis.yml # go.mod # go.sum # utils/utils.go # xray/services/scan.go # xray/services/scan_test.go
# Conflicts: # utils/utils.go
sverdlov93
reviewed
Sep 8, 2023
| @@ -12,6 +12,18 @@ type accessDetails struct { | |||
| auth.CommonConfigFields | |||
| } | |||
|
|
|||
| func (rt *accessDetails) GetXscUrl() string { | |||
There was a problem hiding this comment.
Every Xray manager have this function as this is how we check if you have XSC.
It's build on top of xray.
XrayManager.GetXscUrl -> send get request and then get yes or not.
| @@ -0,0 +1,95 @@ | |||
| package tests | |||
There was a problem hiding this comment.
if a get this right all this test are currently unit tests and they can sit near the xsc service code and no neet the XSC testing suite
There was a problem hiding this comment.
in the client i've put just a simple unit test to make sure things don't break
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
sverdlov93
reviewed
Sep 9, 2023
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
|
open a new pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new XSC service which built on top of Xray.
Any functionality that is not specifically implemented inside XSC will fallback to Xray.
Main changes:
Important note: I didn't change the Xray name as this is the product name for the entire JFrog Security services.
XSC graph scanfunction to support linking scan info into repositories.