Merge pull request #16 from eyalbe4/dev

Isolate the CreateArtifactoryHttpClient API.

artifactory/httpclient.go

@@ -0,0 +1,19 @@
+package artifactory
+
+import (
+	"github.com/jfrog/jfrog-client-go/artifactory/auth/cert"
+	"github.com/jfrog/jfrog-client-go/httpclient"
+	"net/http"
+)
+
+func CreateArtifactoryHttpClient(config Config) (*httpclient.HttpClient, error) {
+	if config.GetCertifactesPath() == "" {
+		return httpclient.NewDefaultHttpClient(), nil
+	}
+
+	transport, err := cert.GetTransportWithLoadedCert(config.GetCertifactesPath())
+	if err != nil {
+		return nil, err
+	}
+	return httpclient.NewHttpClient(&http.Client{Transport: transport}), nil
+}

artifactory/manager.go

@@ -1,15 +1,13 @@
 package artifactory
 
 import (
-	"github.com/jfrog/jfrog-client-go/artifactory/auth/cert"
 	"github.com/jfrog/jfrog-client-go/artifactory/buildinfo"
 	"github.com/jfrog/jfrog-client-go/artifactory/services"
 	"github.com/jfrog/jfrog-client-go/artifactory/services/go"
 	"github.com/jfrog/jfrog-client-go/artifactory/services/utils"
 	"github.com/jfrog/jfrog-client-go/httpclient"
 	"github.com/jfrog/jfrog-client-go/utils/log"
 	"io"
-	"net/http"
 )
 
 type ArtifactoryServicesManager struct {
@@ -20,14 +18,9 @@ type ArtifactoryServicesManager struct {
 func New(config Config) (*ArtifactoryServicesManager, error) {
 	var err error
 	manager := &ArtifactoryServicesManager{config: config}
-	if config.GetCertifactesPath() == "" {
-		manager.client = httpclient.NewDefaultHttpClient()
-	} else {
-		transport, err := cert.GetTransportWithLoadedCert(config.GetCertifactesPath())
-		if err != nil {
-			return nil, err
-		}
-		manager.client = httpclient.NewHttpClient(&http.Client{Transport: transport})
+	manager.client, err = CreateArtifactoryHttpClient(config)
+	if err != nil {
+		return nil, err
 	}
 	if config.GetLogger() != nil {
 		log.SetLogger(config.GetLogger())
@@ -174,4 +167,4 @@ func (sm *ArtifactoryServicesManager) Ping() ([]byte, error) {
 
 func (sm *ArtifactoryServicesManager) GetConfig() Config {
 	return sm.config
-}
+}