Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in latest PR #79

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jun 6, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Fix 2 bugs:

  1. Show image name as target for command summary in docker scan cmd #78: Reference issue, change to imageTag didn't persist.
  2. Run contextual analysis and secret detection in Docker scans #10: If Jas error occur, the SCA result was not set to the results

@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jun 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit e233194 into jfrog:dev Jun 6, 2024
8 of 9 checks passed
@attiasas attiasas deleted the set_res_if_err_in_scan_jas branch June 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants