-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM - Deleted Artifactory server config logic from NPM tree construction #7
Merged
eranturgeman
merged 7 commits into
jfrog:dev
from
eranturgeman:move-rt-server-config-logic-to-cli-core
Jan 24, 2024
Merged
NPM - Deleted Artifactory server config logic from NPM tree construction #7
eranturgeman
merged 7 commits into
jfrog:dev
from
eranturgeman:move-rt-server-config-logic-to-cli-core
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranturgeman
added
improvement
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
labels
Jan 21, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 21, 2024
…o move-rt-server-config-logic-to-cli-core
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 21, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 21, 2024
eranturgeman
added
ignore for release
Automatically generated release notes
and removed
improvement
Automatically generated release notes
labels
Jan 21, 2024
eranturgeman
changed the title
Updated NPM dependencies update to resolve from an Artifactory server if needed
Moved resolution Artifactory server config out of tree construction for NPM
Jan 21, 2024
eranturgeman
changed the title
Moved resolution Artifactory server config out of tree construction for NPM
NPM - Deleted Artifactory server config logic out of the tree construction step
Jan 22, 2024
eranturgeman
had a problem deploying
to
frogbot
January 22, 2024 13:25
— with
GitHub Actions
Failure
…o move-rt-server-config-logic-to-cli-core # Conflicts: # go.mod # go.sum
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 22, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 22, 2024
eranturgeman
requested review from
sverdlov93
and removed request for
attiasas
January 23, 2024 12:47
sverdlov93
reviewed
Jan 23, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 23, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 23, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 24, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 24, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Jan 24, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jan 24, 2024
eranturgeman
changed the title
NPM - Deleted Artifactory server config logic out of the tree construction step
NPM - Deleted Artifactory server config logic from NPM tree construction
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM - Set Artifactory server as a resolution server logic was moved to jfrog-cli-core to npmCommand class so it can be reused.
The current flow in this PR was updated to use the new function from jfrog-cli-core.
Depends on: jfrog/jfrog-cli-core#1108