NPM - Deleted Artifactory server config logic from NPM tree construction #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranturgeman
added
improvement
github-actions
bot
removed
the
safe to test
…o move-rt-server-config-logic-to-cli-core
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
ignore for release
eranturgeman
changed the title
eranturgeman
changed the title
eranturgeman
had a problem deploying
to
frogbot
GitHub Actions
Failure
…o move-rt-server-config-logic-to-cli-core # Conflicts: # go.mod # go.sum
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
requested review from
sverdlov93
and removed request for
attiasas
sverdlov93
reviewed
Jan 23, 2024
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
eranturgeman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM - Set Artifactory server as a resolution server logic was moved to jfrog-cli-core to npmCommand class so it can be reused.
The current flow in this PR was updated to use the new function from jfrog-cli-core.
Depends on: jfrog/jfrog-cli-core#1108