Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting references and usages related to node_modules in NPM SCA/Curation scans #212

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Deleting references and usages related to node_modules in NPM SCA/Curation scans #212

wants to merge 6 commits into from

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Oct 27, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This PR clears all usages and references related to node_modules in NPM code related to SCA scan and Curation scans.
This PR is competing this PR jfrog/build-info-go#280 where we deprecated the utilization of node_modules for the construction of NPM dependencies tree

@eranturgeman eranturgeman changed the title bla Deleting references and usages related to node_modules in NPM Oct 27, 2024
@eranturgeman eranturgeman changed the title Deleting references and usages related to node_modules in NPM Deleting references and usages related to node_modules in NPM SCA/Curation scans Oct 27, 2024
@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Oct 27, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 27, 2024
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
8673c72 
…o remove-node-modules-uage-in-npm-tree-calc
@eranturgeman
Merge remote-tracking branch 'eran-fork/remove-node-modules-uage-in-n…
3026483 
…pm-tree-calc' into remove-node-modules-uage-in-npm-tree-calc
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eranturgeman