Add logs and add error if serverDetails not provided

[attiasas]

• The pull request is targeting the dev branch.
• The code has been validated to compile successfully by running go vet ./....
• The code has been formatted properly using go fmt ./....
• All static analysis checks passed.
• All tests have passed. If this feature is not already covered by the tests, new tests have been added.
• All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

---

• Refactor JAS run task to a separate function.
• Added some logs to report when not entitled / not provided details
• Return Error if server details are nil at the point of creating the JAS scanner (it should already exists since we ended entitlement request successfully

[github-actions]

---

🐸 JFrog Frogbot

[eranturgeman]

Under which circumstances that weren't exist before the jasScanner can be nil after we tried to create it? If it is not trivial to infer - please add a comment what can result this

[attiasas]

look at CreateScanner. if len(serverDetails.Url) == 0 is true we log the usual warning and return nil scanner, we should not continue after that just like the check was at JasRunner. we need a way to separate the case that serverDetails is nil (err, should not be nil at this point) or the user did not configure the right things (URL, warning)

[eranturgeman]

why are we doing this here? what is changed in the logic that we didn't need it before and now we do?

[attiasas]

Nothing has changed. the logic was just moved from one place to another. (Refactoring...)

[eranturgeman]

I reviewed the changes, there are few things that are unclear to me (see my comments)
Also, about the serverDetails logs, do you think it would suffice to understand the issue with the POC? We know already they dont have the serverDetails or the ServerUrl at this point. In my PR I wanted to understand what they do have (xrayUrl, artifactoryUrl..) or if they lose this data during the process