Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legal info message to git count command and change flags to manda… #170

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Add legal info message to git count command and change flags to manda… #170

merged 4 commits into from
Sep 11, 2024

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Sep 10, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@orz25 orz25 added safe to test Approve running integration tests on a pull request labels Sep 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@orz25 orz25 added the ignore for release Automatically generated release notes label Sep 11, 2024
@attiasas attiasas self-requested a review September 11, 2024 10:59
attiasas
attiasas approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas mentioned this pull request Sep 11, 2024
Closed
@orz25 orz25 merged commit ab956e5 into jfrog:dev Sep 11, 2024
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orz25 @attiasas