Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support browser login requests #732

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Support browser login requests #732

merged 2 commits into from
Jun 28, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented May 23, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Required for:

Add 2 new APIs required for SSO login:

  1. SendBrowserLoginRequest
  2. GetBrowserLoginRequestToken

Allow anonymous access in JFrog Access REST APIs.

@yahavi yahavi added the new feature Automatically generated release notes label May 23, 2023
@yahavi yahavi self-assigned this May 23, 2023
@yahavi yahavi temporarily deployed to frogbot May 23, 2023 06:40 — with GitHub Actions Inactive
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label May 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2023
@github-actions
Copy link

What is Frogbot?

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label May 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2023
@yahavi yahavi marked this pull request as ready for review June 18, 2023 09:30
@yahavi yahavi requested a review from eyalbe4 June 18, 2023 09:31
@yahavi yahavi mentioned this pull request Jun 18, 2023
Merged
1 task
@yahavi yahavi requested a review from talarian1 June 18, 2023 12:48
@yahavi yahavi merged commit 9920d45 into jfrog:master Jun 28, 2023
1 check failed
@yahavi yahavi deleted the browser-login branch June 28, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talarian1 talarian1 talarian1 left review comments

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @talarian1