-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to run ADT calls over RFC #64
base: master
Are you sure you want to change the base?
Conversation
Main effort is to split Connection in sap/adt/core.py into ConnectionViaRFC and ConnectionViaHTTP.
Good job! I was always wondering how that RFC HTTP tunneling works :) I am happy to merge once we get rid of those unnecessary style fixes and all tests and linters are satisfied. |
Revert changes to formating Revert to old requirements.txt and move urllib3 back
Thank you. I must have accidentally run |
@@ -86,6 +86,11 @@ def parse_command_line(argv): | |||
help="SAP Secure Login Client library (e.g. " | |||
"/Applications/Secure Login Client.app/Contents/MacOS/lib/libsapcrypto.dylib") | |||
|
|||
arg_parser.add_argument("--rest-over-rfc", action='store_true', dest="rest_over_rfc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, I didn't notice earlier. The generic name 'rest-over-rfc' suggest that all HTTP traffic will be routed via RFC but I do believe only ADT HTTP traffic can be tunneled via RFC. Am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a very interesting question. In theory, all of the HTTP requests can be tunneled because it directly connects to the HTTP dispatcher on Netweaver Server. However, I did not try with other types of requests and it is not implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so since the implementation does not route entire HTTP traffic via RFC, I suggest to rename to "adt_rest_over_rfc".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point.
I think it is better to keep the name but show an error message. With this, the parameter would not have to change if this is also implemented for gtcs. This is ultimately your call.
Please update |
|
- Fix sapcli test (rename `group` to `rfc_group` - Fix type hints for python 3.8 (Dict[...] instead of dict[..])
I think I know what this is: For older version on has to use something like this
@lucasborin I updated the code. |
Unsure if I did something wrong, but my python is not able to find PyRFC anymore before pulling it. I'll try to redo my setup. |
Main effort is to split Connection in
sap/adt/core.py
intoConnectionViaRFC
andConnectionViaHTTP
.I don't have many test for this as this would require a Netweaver Server.