tree-wide: add support for ABAP DDIC Data Element CRUD

[buca92]

No description provided.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (9c033e2) 98.25% compared to head (7ca8567) 98.29%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   98.25%   98.29%   +0.03%     
==========================================
  Files          84       86       +2     
  Lines        8315     8483     +168     
==========================================
+ Hits         8170     8338     +168     
  Misses        145      145              

Files Changed	Coverage Δ
sap/adt/__init__.py	100.00% <100.00%> (ø)
sap/adt/dataelement.py	100.00% <100.00%> (ø)
sap/adt/objects.py	98.80% <100.00%> (+<0.01%)	⬆️
sap/cli/__init__.py	90.32% <100.00%> (+0.10%)	⬆️
sap/cli/dataelement.py	100.00% <100.00%> (ø)
sap/rest/gcts/sugar.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jfilak]

Since data elements have no text definitions yet. I propose to modify the operation "create" to accept the same parameters as the operation "chattr", to avoid the need to issue 2 commands "create + chattr". The operations "create" and "chattr", should also have the patameter "-a|--activate" to create, define and activate a data element in a signle command. I would also add the option "--overwrite" to the operation create, so it does not fail if the created data element already exists.

[jfilak]

We may have Data Elements text in future: SAP/abap-file-formats#556

[buca92]

Since data elements have no text definitions yet. I propose to modify the operation "create" to accept the same parameters as the operation "chattr", to avoid the need to issue 2 commands "create + chattr". The operations "create" and "chattr", should also have the patameter "-a|--activate" to create, define and activate a data element in a signle command. I would also add the option "--overwrite" to the operation create, so it does not fail if the created data element already exists.

Ok, I will create the "define" action that will take care of whole DTEL lifecycle from creation to activation phase

[buca92]

I pushed new version of SAPCLI Data Element handling.

New command define is introduced and covers create, change and activation phases, all that are relevant for a consumer.

See example: sapcli dataelement define Z_TEST_DTEL "Test DTEL created via SAPCLI" '$Z_PLAYGROUND' --activate --no-error-existing --type=predefinedAbapType --data_type=STRING --label_short='Tst DTEL' --label_medium='Test Label Medium' --label_long='Test Label Long' --label_heading='Test Label Heading'

[jfilak]

Tested but the force pushed commit is not presetn yet: buca92@7ca8567#diff-01319a9d5bb09fa62975ace1e4391b81e6d263af504892bae6dcd4463fdf846fR497

[buca92]

It is already there ;). Even the Coverage Report shows 100 % again

[jfilak]

Well done. I pushed these commits:

• 68d161b adt: avoid adding trailing slash into uri if it is not necessary
• 59ba457 tree-wide: add support for ABAP DDIC Data Element CRUD