remove cuego.Complete from cuecfg.Marshal

[savil]

Summary

cuego.Complete leads to non-trivial complexity when dealing with custom json
marshalling. In particular, it does a round-trip JSON marshal/unmarshal and fields
that are not handled by golang's json-framework can be lost. This interferes
with custom marshalling/unmarshalling.

cuego.Complete is only needed if we rely on the cue: annotations to autocomplete some fields (I mean, assign default values respecting cue constraints). We don't rely on this, so, right now it is superfluous.

I also remove the cue: annotations in a couple of structs since we do not
rely on them.

How was it tested?

• devbox init should produce the expected output
• devbox add
• devbox rm

testscript unit tests must pass

[savil]

Current dependencies on/for this PR:

• main
  • PR remove cuego.Complete from cuecfg.Marshal #1349 👈
    • PR [Config Packages] Enable optional map spec #1351

This comment was auto-generated by Graphite.

[mikeland73]

I had no idea what this was for, thanks for description cc: @loreto

[loreto]

LGTM

I don't know if there's other places where cue is handling the config, but at this point, you might as well remove the dependency completely.

cuecfg is a misnomer now, you might want to rename the package.