Disable a test for new MacOS libcurl

jeroen · Aug 9, 2024 · 903262b · 903262b
1 parent 3a1fa67
commit 903262b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: curl
 Type: Package
 Title: A Modern and Flexible Web Client for R
-Version: 5.2.1
+Version: 5.2.1.9000
 Authors@R: c(
  person("Jeroen", "Ooms", role = c("aut", "cre"), email = "[email protected]",
  comment = c(ORCID = "0000-0002-4035-0289")),

diff --git a/NEWS b/NEWS
@@ -1,3 +1,6 @@
+5.2.2
+ - Disable a compression test for libcurl 8.7.1 which has a bug for deflate
+
 5.2.1
  - In handle_setheader(), setting a header to a non-empty whitespace string will
  now send a blank header. Using an empty string will still remove the header

diff --git a/tests/testthat/test-connection.R b/tests/testthat/test-connection.R
@@ -3,6 +3,8 @@ context("Connections")
 h <- new_handle()
 
 test_that("Compression and destroying connection", {
+ # Compression is broken in 8.7.1, see https://github.com/curl/curl/issues/13493
+ skip_if(curl::curl_version()$version == '8.7.1')
  con <- curl(httpbin("deflate"), handle = h)
  expect_equal(jsonlite::fromJSON(readLines(con))$deflate, TRUE)
  expect_false(isOpen(con))