Skip to content

Commit

Permalink
Revert "Avoid FixedArray types which are missing in NodeJS"
Browse files Browse the repository at this point in the history
This reverts commit 223f144.
  • Loading branch information
jeroen committed Oct 5, 2024
1 parent 223f144 commit e0bdff9
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/bindings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,9 @@ static void fatal_cb(const char* location, const char* message){

static v8::Local<v8::Module> read_module(std::string filename, v8::Local<v8::Context> context);

template <typename DUMMY>
static v8::MaybeLocal<v8::Module> ResolveModuleCallback(v8::Local<v8::Context> context,
v8::Local<v8::String> specifier,
DUMMY import_attributes,
v8::Local<v8::FixedArray> import_attributes,
v8::Local<v8::Module> referrer) {
v8::String::Utf8Value name(context->GetIsolate(), specifier);
return read_module(*name, context);
Expand Down Expand Up @@ -118,12 +117,11 @@ static v8::MaybeLocal<v8::Promise> ResolveDynamicModuleCallback(

#else

template <typename DUMMY>
static v8::MaybeLocal<v8::Promise> ResolveDynamicModuleCallback(
v8::Local<v8::Context> context,
v8::Local<v8::ScriptOrModule> referrer,
v8::Local<v8::String> specifier,
DUMMY import_assertions) {
v8::Local<v8::FixedArray> import_assertions) {
return dynamic_module_loader(context, specifier);
}

Expand Down

0 comments on commit e0bdff9

Please sign in to comment.