Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GroovyScript for agent and controller #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtughan
Copy link
Contributor

@mtughan mtughan commented Jun 23, 2023

Make GroovyScript simpler by separating the parts meant only for the controller into a new class that extends GroovyScript. This also makes the intention of each class and the differences between them clearer from the names themselves.

Testing done

Submitter checklist

@mtughan mtughan force-pushed the split-groovy-script branch 2 times, most recently from 5e05896 to 2c00ff2 Compare June 23, 2023 18:00
Make GroovyScript simpler by separating the parts meant only for the
controller into a new class that extends GroovyScript. This also makes
the intention of each class and the differences between them clearer
from the names themselves.
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Not manually tested.

@mtughan mtughan added the chore label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants