customization of rtc accept command output

[vvidovic]

Hello,

at work we use RTC version 3.1.100 and Jenkins RTC plugin didn't work well with it. Plugin failed after each accept because RCT accept command output was different from the expected one.

I see there are two parsers (old and new one) and I added the third one which is used in case user defines three custom environment variables:
RTC_ACCEPT_OUT_PATTERN_STARTCHANGESET
RTC_ACCEPT_OUT_PATTERN_FILE
RTC_ACCEPT_OUT_PATTERN_WORKITEM

When I start Jenkins I set this three variables to following values and now plugin works fine:
"^\s{6}((\d+))\s(.)", "^\s{10}---(.)-\s+(.)" and "^\s{10}((\d+))+(.*)"

This way there is no need to update plugin each time rtc accept output changes.

Also I fixed few minor spelling errors (changed "itens" to "items").

Could you please accept this changes to main rtc-plugin code?

Thanks,
Vedran

[buildhive]

Jenkins » rtc-plugin #7 FAILURE
Looks like there's a problem with this pull request
(what's this?)

[buildhive]

Jenkins » rtc-plugin #8 SUCCESS
This pull request looks good
(what's this?)

[ilx]

Can this be merged?

[RoystonS]

It's nice that the new parser is customizable, but really the plugin should know (rather than having to be told for each build slave) which format to use, given the detected version. I've been using this patch but having to specify the formats via environment variables (which requires a Jenkins restart if the tool version changes and doesn't really fit with the other Jenkins per-slave configuration value mechanism) is a bit messy when you have a whole bunch of build slaves.

The other alternative pull request #5 is much simpler to work with as it auto-detects 3.1.100 and the other versions without any other input needed, but yes, would require code change for future versions. I'd hope that the RTC developers are trying to alleviate that with the machine-readable JSON output support.

[ilx]

@RoystonS Take a look at https://groups.google.com/d/topic/jenkinsci-dev/aFN3wcTt2Sw/discussion

It's IBM's turn to fix jenkins plugin for it's own product

[RoystonS]

Funny you should mention that. I now work at IBM, and am currently working through the approval process to be able to contribute to this plugin.

[ilx]

@RoystonS I'm not sure I understand: you work on the above mentioned plugin that uses IBM RTC client libaries or you work on this one that parses rtc output? :)

I hope you get permission to contribute to this plugin. I just hope we don't end up with 2 different plugins with similar names.

[RoystonS]

Ah, sorry, I hadn't noticed that link - apologies.

I hadn't realised that there was independent work going on in RTC itself to provide some Jenkins support. That sounds like an excellent long-term approach, and should provide a more stable and more efficient plugin. No, I'm not involved with that, but I look forward to being able to use it.

I'm concerned with the short term operation of RTC with Jenkins, so I'm hoping to be able to do some minor short-term 'shoring up' for this plugin here.

[deluan]

Hi All,

Sorry for not being able to participate in this discussion, but besides not
working with RTC anymore, I'm moving to another country and really don't
have time to focus on this plugin anymore :(

Royston,

if you need some help and if you would like to take over this plugin, let
me know. There are some pull requests that needs to be merged and some real
good suggestions on the forums that could be implemented.

-Deluan

On Fri, Feb 22, 2013 at 7:34 AM, Royston Shufflebotham <
[email protected]> wrote:

Ah, sorry, I hadn't noticed that link - apologies.

I hadn't realised that there was independent work going on in RTC itself
to provide some Jenkins support. That sounds like an excellent long-term
approach, and should provide a more stable and more efficient plugin. No,
I'm not involved with that, but I look forward to being able to use it.

I'm concerned with the short term operation of RTC with Jenkins, so I'm
hoping to be able to do some minor short-term 'shoring up' for _this_plugin here.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/6#issuecomment-13937198.

[RoystonS]

(This is getting rather off-topic on this pull request, but I got the permission through. Deluan, I'll contact you directly to avoid spamming this pull further!)

[aelmadho]

Hi,

Is there any update on this?

[RoystonS]

@deluan, tried to contact you via Twitter, but not sure it worked, and github won't let me message you directly any more. Would you mind pinging me and we can take it further? My contact details are on my github profile page. Thanks! (Apologies for hijacking this issue again! :-()

[nexeh]

@RoystonS, Im blocked by this issue as well. Have you made contact with @deluan to take this over? Contact me directly if you want to avoid spamming the pull request. Also I maybe able to assist in supporting this project.

[RoystonS]

Yes, I've got commit access now. I'm hoping to get this (and/or the other equivalent pull request) merged in the next few days, but the issues from pull request #7 have been even more urgent.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests