Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default size of diagnostic buffer for FlightRecorderInputStream from 1MiB to 1KiB #9887

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dwnusbaum
Copy link
Member

Refiling jenkinsci/remoting#770 against the duplicated class here.

Testing done

I added a new test to cover the FlightRecorderInputStream diagnostics for the CLI.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@dwnusbaum dwnusbaum added the skip-changelog Should not be shown in the changelog label Oct 18, 2024
final PipedOutputStream upload = new PipedOutputStream();
final PipedOutputStream download = new PipedOutputStream();

class Server extends PlainCLIProtocol.ServerSide {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally was going to put this in the CLI module's unit tests, but without LoggerRule I had no way to write any assertions related to the FlightRecorderInputStream diagnostics.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably just get rid of the recorder in the CLI. I doubt it has ever been used. (The protocol is far simpler than that of Remoting anyway.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants