Display appropriate GUI that accurately displays offline by design #9883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked computer icon and associated descriptions to be controlled by the
OfflineCause
implementation. For implementations such asRetentionStrategy.Demand
, this allows to set an offline cause that can't be interpreted by the end user as an error.pause
andcomputer-paused
symbols, used by the on-demand retention strategy to indicate the computer is offline on purpose and is not in error stategetOfflineCause
toIComputer
and refactor related methods to pull up methods that make sense at the interface level.IOfflineCause
interface fromOfflineCause
to make it possible to render offline causes in other runtimes (CloudBees CI HA)Screenshots
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist