This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
Dockerfile
build: removesmkdir
commands (directories are created withWORKDIR
instructions), pipescurl
packages totar
, makes variables easier to override in builds usingdocker
ARG
's to set theENV
(note: might break thejx step create pr
), fixes thehelm3
download using theENV
variable, aliases thedocker
stages, consolidates and sorts and splitsyum
package installation on multiple lines following best practices.Dockerfile
can be linted usinghadolint
:docker run --rm -i hadolint/hadolint < Dockerfile
- directories created bymake
are ignored inline.