Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert 'GitHubAPI' to Java #3820

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

detunjiSamuel
Copy link

Description

Converted GitHubAPI.groovy to GitHubAPI.java as per the below issue.

Issue: #3028

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @username1
  • @username2

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

CD checklist (for submitters)

Reviewer checklist

There are IRC Bot commands for it.

@detunjiSamuel detunjiSamuel requested a review from a team as a code owner March 17, 2024 17:33
@NotMyFault
Copy link
Member

In the best case, this change should only be merged, if you write tests covering the existing functionality in a different PR, to ensure your changes proposed are non-breaking.

@detunjiSamuel
Copy link
Author

Just to confirm, do I need to include the test cases in this PR?

@NotMyFault
Copy link
Member

in a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants